New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and rename showDebugger() method #131

Open

nateplusplus opened this issue May 10, 2022 · 0 comments

Labels

Owner

nateplusplus commented May 10, 2022

showDebugger is basically a helper function that doesn't need to be part of the pushIn class.
It's not really a debugger either, it shows the current scrollY value. Should be named something more appropriate.

This could be moved into a new class and could be called like:

import { PushInScrollHelper } from pushin;

PushInScrollHelper::show();

I think it should still be included on the global scope too, for those who are using a CDN.

pushInScrollHelper();

nateplusplus added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment