Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straight quotes or markup in headings breaks html #31

Open
chadananda opened this issue May 4, 2024 · 0 comments
Open

Straight quotes or markup in headings breaks html #31

chadananda opened this issue May 4, 2024 · 0 comments

Comments

@chadananda
Copy link

Hi, I just noticed that all headers containing quotation marks or markdown break the html on the page.

I removed the heading component and noticed that the text is stored in an attribute like:

### Highlights of Violetta’s Interview

<heading as="h3" text="Highlights of Violetta’s Interview">Highlights of Violetta’s Interview</heading>

Adding some quotes around "of", for example, renders:

### Highlights "of" Violetta’s Interview

<heading as="h3" text="Highlights " of"="" violetta="’s" interview="" "="">Highlights “of” Violetta’s Interview</heading>

You can see how this is totally messed up. When it's passed to the Heading component, the text prop is mangled. Unfortunately, straight quotes are pretty common in headers.

Similar problems crop up with formatting in the headers.

"astro-remote": "^0.3.3",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant