Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6695: Machine-readable operational mode support for traceroute #2

Closed
wants to merge 1 commit into from

Conversation

natali-rs1985
Copy link
Owner

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op-mode

Proposed changes

How to test

vyos@vyos:~$ curl -k --location --request POST 'https://localhost/traceroute' --form data='{"op": "traceroute", "host": "192.0.2.1"}' --form key='foo'
{"success": true, "data": "{\n    \"report\": {\n        \"mtr\": {\n            \"src\": \"vyos\",\n            \"dst\": \"192.0.2.1\",\n            \"tos\": 0,\n            \"tests\": 1,\n            \"psize\": \"64\",\n            \"bitpattern\": \"0x00\"\n        },\n        \"hubs\": [\n            {\n                \"count\": 1,\n                \"host\": \"192.168.122.1\",\n                \"Loss%\": 0.0,\n                \"Snt\": 1,\n                \"Last\": 1.475,\n                \"Avg\": 1.475,\n                \"Best\": 1.475,\n                \"Wrst\": 1.475,\n                \"StDev\": 0.0\n            },\n            {\n                \"count\": 2,\n                \"host\": \"192.168.179.2\",\n                \"Loss%\": 0.0,\n                \"Snt\": 1,\n                \"Last\": 2.383,\n                \"Avg\": 2.383,\n                \"Best\": 2.383,\n                \"Wrst\": 2.383,\n                \"StDev\": 0.0\n            },\n            {\n                \"count\": 3,\n                \"host\": \"???\",\n                \"Loss%\": 100.0,\n                \"Snt\": 1,\n                \"Last\": 0.0,\n                \"Avg\": 0.0,\n                \"Best\": 0.0,\n                \"Wrst\": 0.0,\n                \"StDev\": 0.0\n            }\n        ]\n    }\n}\n", "error": null}

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

Copy link

✅ No issues found in unused-imports check.. Please refer the workflow run

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant