-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
class websites deploying without student or tech data #1
Comments
This commit by @stevebrownlee removes the deploy workflow and adds several assets and dependencies on the We need to get the dev and main branches in sync and test. This was the solution to resolving the E65 deploy issue, but a PR shows there are many other dependencies that may need testing; however, it may have been a quick fix. |
Just jumping in here, the deploy.yml file has to be present for it to deploy to github pages. Also the dev and main branches won't match because the gh-pages package is bundling all the files on the develop branch so the code can be deployed to github pages. |
@hannahhall so to clarify when making simple updates to the UI, we should be doing that against which branch? |
Never mind. I see on the removed readme to do it against develop and then run the deploy command. |
Yeah and then the deploy command is really only needed if you're making changes to a class's actual repo. Deploying this repo doesn't matter because it's just the template that the class repo will copy and then build |
Yeah. It was in reference to separate repos just in case so it all make sense. Thank you!! |
When deploying a new cohort site, the site does not populate with student or tech data. the template now appears to be missing its deploy file.
The text was updated successfully, but these errors were encountered: