Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class websites deploying without student or tech data #1

Open
joshdbarton opened this issue Sep 28, 2023 · 6 comments
Open

class websites deploying without student or tech data #1

joshdbarton opened this issue Sep 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@joshdbarton
Copy link

When deploying a new cohort site, the site does not populate with student or tech data. the template now appears to be missing its deploy file.

@joshdbarton joshdbarton added the bug Something isn't working label Sep 28, 2023
@drteresavasquez
Copy link
Member

drteresavasquez commented Sep 28, 2023

This commit by @stevebrownlee removes the deploy workflow and adds several assets and dependencies on the main branch. Not sure if this was intentional.

We need to get the dev and main branches in sync and test. This was the solution to resolving the E65 deploy issue, but a PR shows there are many other dependencies that may need testing; however, it may have been a quick fix.

@hannahhall
Copy link
Contributor

Just jumping in here, the deploy.yml file has to be present for it to deploy to github pages. Also the dev and main branches won't match because the gh-pages package is bundling all the files on the develop branch so the code can be deployed to github pages.

@drteresavasquez
Copy link
Member

drteresavasquez commented Sep 28, 2023

@hannahhall so to clarify when making simple updates to the UI, we should be doing that against which branch?

@drteresavasquez
Copy link
Member

Never mind. I see on the removed readme to do it against develop and then run the deploy command.

@hannahhall
Copy link
Contributor

Yeah and then the deploy command is really only needed if you're making changes to a class's actual repo. Deploying this repo doesn't matter because it's just the template that the class repo will copy and then build

@drteresavasquez
Copy link
Member

Yeah. It was in reference to separate repos just in case so it all make sense. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants