fprime-util new --project doesn't prompt for fprime branch/tag and creates an fprime submodule checked out at devel as of fprime-tools v3.4.0

[capsulecorplab]

F´ Version	3.4.0
Affected Component

---

Problem Description

Haven't tested to see if the same behavior exists in fprime-tools v3.4.1, but at least in v3.4.0, fprime-util new --project creates an fprime submodule checked out at a grafted HEAD commit at devel without prompting for fprime branch/tag as described in Creating a New F' Project; I'd have to manually cd into the fprime submodule, run git fetch --tags followed by git checkout v3.4.0

How to Reproduce

1. pip install fprime-tools==3.4.0
2. fprime-util new --project # enter MyFPrimeProject for project name
3. cd MyFPrimeProject/fprime
4. git show HEAD

Expected Behavior

fprime-util new --project should prompt for fprime branch/tag as to be able to pin fprime submodule to a version, s.a., v3.4.0

[thomas-bc]

Thanks for reporting this bug - this is indeed something that slipped through our testing. Opened nasa/fprime-tools#191 to fix it

Not prompting for a version is intended though, we made the decision for the tool to checkout the latest release only. This makes its usage simpler, and still allows experimented users to checkout earlier versions if needed.

[thomas-bc]

Also just FYI, we're planning in the near future to take fprime-util new --project out of fprime-util and into a standalone bootstrap tool -- see #2477

[capsulecorplab]

Thanks for reporting this bug - this is indeed something that slipped through our testing. Opened fprime-community/fprime-tools#191 to fix it

Not prompting for a version is intended though, we made the decision for the tool to checkout the latest release only. This makes its usage simpler, and still allows experimented users to checkout earlier versions if needed.

I'm confused, so is it by design that fprime-tools isn't prompting for a branch or tag now or is it a bug? I kind of preferred the v3.3.2 behavior when it did prompt for a branch or tag (albeit, with the default option was set to devel)

[thomas-bc]

It is by design. It was causing issues here with fprime-tools rewriting itself during execution (fprime-util new --project installs in current venv), among other things. We may reconsider when we have the new bootstrap tool as this will alleviate most of the concerns.