Ambiguous overload for operator -- cross-compile `riscv64-unknown-elf-` #1484

ThibFrgsGmz · 2022-06-01T16:16:47Z

ThibFrgsGmz
Jun 1, 2022

Hello folks,

I'm doing a cross-compilation for RISC-V CPU + FreeRTOS and I have several errors concerning ambiguous overloads like :

[ 43%] Generating ActiveLogger_FilterSeverityEnumAc.hpp, ActiveLogger_FilterSeverityEnumAc.cpp
Parsing Enum ActiveLogger_FilterSeverity
Completed generating files for /home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/ActiveLogger/ActiveLogger_FilterSeverityEnumAi.xml Enum XML....
Scanning dependencies of target Svc_ActiveLogger
[ 43%] Building CXX object F-Prime/Svc/ActiveLogger/CMakeFiles/Svc_ActiveLogger.dir/ActiveLoggerImpl.cpp.obj
/home/ThibFrgsGmz/Documents/fprime-poc/fprime/Svc/ActiveLogger/ActiveLoggerImpl.cpp: In constructor 'Svc::ActiveLoggerImpl::ActiveLoggerImpl(const char*)':
/home/ThibFrgsGmz/Documents/fprime-poc/fprime/Svc/ActiveLogger/ActiveLoggerImpl.cpp:24:69: error: ambiguous overload for 'operator=' (operand types are 'Svc::ActiveLogger_Enabled' and 'Svc::ActiveLogger_Enabled::t')
                 FILTER_WARNING_HI_DEFAULT?Enabled::ENABLED:Enabled::DISABLED;
                                                                     ^~~~~~~~
In file included from /home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/ActiveLogger/ActiveLoggerComponentAc.hpp:22,
                 from /home/ThibFrgsGmz/Documents/fprime-poc/fprime/Svc/ActiveLogger/ActiveLoggerImpl.hpp:11,
                 from /home/ThibFrgsGmz/Documents/fprime-poc/fprime/Svc/ActiveLogger/ActiveLoggerImpl.cpp:10:
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/ActiveLogger/ActiveLogger_EnabledEnumAc.hpp:72:27: note: candidate: 'Svc::ActiveLogger_Enabled& Svc::ActiveLogger_Enabled::operator=(const Svc::ActiveLogger_Enabled&)'
     ActiveLogger_Enabled& operator=(
                           ^~~~~~~~
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/ActiveLogger/ActiveLogger_EnabledEnumAc.hpp:77:27: note: candidate: 'Svc::ActiveLogger_Enabled& Svc::ActiveLogger_Enabled::operator=(NATIVE_INT_TYPE)'
     ActiveLogger_Enabled& operator=(
                           ^~~~~~~~
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/ActiveLogger/ActiveLogger_EnabledEnumAc.hpp:82:27: note: candidate: 'Svc::ActiveLogger_Enabled& Svc::ActiveLogger_Enabled::operator=(NATIVE_UINT_TYPE)'
     ActiveLogger_Enabled& operator=(
                           ^~~~~~~~

If you know, could you tell me how to get rid of this error in a clean way please?

I also had this error on the serialization/deserialization methods of command messages which I solved by writing in my StandardTypes.hpp file:

#define FPRIME_OVERRIDE_NATIVE_TYPES
typedef int32_t NATIVE_INT_TYPE; //!< native integer type declaration
typedef uint32_t NATIVE_UINT_TYPE; //!< native unsigned integer type declaration

Is this the best way to correct this type of error?

According to fprime/Fw/Types/BasicTypes.hpp these native types should be redefined for systems with malformed stdint.h.

Can you explain to me what exactly "malformed" means?

Answered by kevin-f-ortega

Jun 1, 2022

@ThibFrgsGmz what version of F Prime are you using? This bug looks very familiar to the bugs fixed by #1462.

View full answer

ThibFrgsGmz · 2022-06-01T16:45:11Z

ThibFrgsGmz
Jun 1, 2022
Author

In the meantime I statically cast the ActiveLoggerComponentBase(name) method to move forward:

ActiveLoggerImpl::ActiveLoggerImpl(const char* name) : 
     ActiveLoggerComponentBase(name)
{
     // set filter defaults
     this->m_filterState[FilterSeverity::WARNING_HI].enabled =
               FILTER_WARNING_HI_DEFAULT? static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);
     this->m_filterState[FilterSeverity::WARNING_LO].enabled =
               FILTER_WARNING_LO_DEFAULT?static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);
     this->m_filterState[FilterSeverity::COMMAND].enabled =
               FILTER_COMMAND_DEFAULT?static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);
     this->m_filterState[FilterSeverity::ACTIVITY_HI].enabled =
               FILTER_ACTIVITY_HI_DEFAULT?static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);
     this->m_filterState[FilterSeverity::ACTIVITY_LO].enabled =
               FILTER_ACTIVITY_LO_DEFAULT?static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);
     this->m_filterState[FilterSeverity::DIAGNOSTIC].enabled =
               FILTER_DIAGNOSTIC_DEFAULT?static_cast<NATIVE_INT_TYPE>(Enabled::ENABLED):static_cast<NATIVE_INT_TYPE>(Enabled::DISABLED);

     memset(m_filteredIDs,0,sizeof(m_filteredIDs));

}

Even if it works, I wonder if it's a mistake on my side by having misconfigured something in the framework.

Otherwise if it is a real error in the code, I can submit by PR the static_cast that I had to add to crosscompile in riscv.

0 replies

Joshua-Anderson · 2022-06-01T17:00:33Z

Joshua-Anderson
Jun 1, 2022

Nope, this is a genuine issue! I suspect when we start testing with newer versions of clang / gcc we'd see the same warning. It's warning that we're assigning the raw enum value ( an int), rather than the enum class (a C++ class). What we should do is assign a Svc::ActiveLogger_Enabled to fileState instead.

2 replies

Joshua-Anderson Jun 1, 2022

Now that I think about this for a few seconds longer maybe there's something wrong with the ActiveLogger_Enabled constructors that prevent casting to ActiveLogger_Enabled from a ActiveLogger_Enabled::t

ThibFrgsGmz Jun 2, 2022
Author

Good point, @kevin-f-ortega corrected it a little while ago! Look at his comment marked as "answered ".

ThibFrgsGmz · 2022-06-01T17:19:56Z

ThibFrgsGmz
Jun 1, 2022
Author

@Joshua-Anderson Well, now it's in the autogenerated code that I have this ambiguous cast error:

Completed generating files for /home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileStatusEnumAi.xml Enum XML....
Scanning dependencies of target Svc_FileDownlinkPorts
[ 60%] Building CXX object F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/SendFileCompletePortAc.cpp.obj
[ 60%] Building CXX object F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/SendFileRequestPortAc.cpp.obj
[ 61%] Building CXX object F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/SendFileResponseSerializableAc.cpp.obj
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileResponseSerializableAc.cpp: In constructor 'Svc::SendFileResponse::SendFileResponse()':
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileResponseSerializableAc.cpp:13:43: error: ambiguous overload for 'operator=' (operand types are 'Svc::SendFileStatus' and 'Svc::SendFileStatus::t')
     this->m_status = Svc::SendFileStatus::STATUS_OK;
                                           ^~~~~~~~~
In file included from /home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileResponseSerializableAc.hpp:21,
                 from /home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileResponseSerializableAc.cpp:1:
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileStatusEnumAc.hpp:74:21: note: candidate: 'Svc::SendFileStatus& Svc::SendFileStatus::operator=(const Svc::SendFileStatus&)'
     SendFileStatus& operator=(
                     ^~~~~~~~
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileStatusEnumAc.hpp:79:21: note: candidate: 'Svc::SendFileStatus& Svc::SendFileStatus::operator=(NATIVE_INT_TYPE)'
     SendFileStatus& operator=(
                     ^~~~~~~~
/home/ThibFrgsGmz/Documents/fprime-poc/App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileStatusEnumAc.hpp:84:21: note: candidate: 'Svc::SendFileStatus& Svc::SendFileStatus::operator=(NATIVE_UINT_TYPE)'
     SendFileStatus& operator=(
                     ^~~~~~~~
make[3]: *** [F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/build.make:134: F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/SendFileResponseSerializableAc.cpp.obj] Error 1
make[2]: *** [CMakeFiles/Makefile2:4783: F-Prime/Svc/FileDownlinkPorts/CMakeFiles/Svc_FileDownlinkPorts.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2189: CMakeFiles/App.dir/rule] Error 2
make: *** [Makefile:165: App] Error 2
[ERROR] CMake erred with return code 2

This is the result in the autogenerated App/build-fprime-automatic-riscv-soc-freertos/F-Prime/Svc/FileDownlinkPorts/SendFileResponseSerializableAc.cpp:

#include <Svc/FileDownlinkPorts/SendFileResponseSerializableAc.hpp>
#include <Fw/Types/Assert.hpp>
#include <Fw/Types/BasicTypes.hpp>
#include <Fw/Types/StringUtils.hpp>
#if FW_SERIALIZABLE_TO_STRING
#include <Fw/Types/String.hpp>
#endif
#include <cstring>
namespace Svc {
// public methods

SendFileResponse::SendFileResponse(): Serializable() {
    this->m_status = Svc::SendFileStatus::STATUS_OK;
    this->m_context = 0;
}

So I try to modify the autocoder to add a static_cast<$type> in fprime/Autocoders/Python/src/fprime_ac/generators/templates/serialize/publicSerialCpp.tmpl but it does not appear in the generated file.

// public methods
${name}::${name}(): Serializable() {
#for ($member,$type,$array_size,$size,$format,$comment,$default,$typeinfo) in $members:
#if $default != None and $array_size != None:
    for (NATIVE_INT_TYPE _mem = 0; _mem < ${array_size}; _mem++) {
        this->m_${member}[_mem] = static_cast<$type>(${default});
    }
#else if $default != None:
    this->m_${member} = ${default};
#end if
#end for
}

Work in progress...

2 replies

Joshua-Anderson Jun 1, 2022

If you modify the autocoded templates you usually need to delete and regenerate your build cache to regenerate the templates.

ThibFrgsGmz Jun 1, 2022
Author

Yeah I did the purge but the static_cast did not appear, I will see more in detail tomorrow!

kevin-f-ortega · 2022-06-01T18:51:43Z

kevin-f-ortega
Jun 1, 2022
Maintainer

@ThibFrgsGmz what version of F Prime are you using? This bug looks very familiar to the bugs fixed by #1462.

1 reply

ThibFrgsGmz Jun 2, 2022
Author

Awesome! Indeed, I just took your commit and it solved those ambiguous overload errors, thanks for your help!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ambiguous overload for operator -- cross-compile `riscv64-unknown-elf-` #1484

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 4 comments 5 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

Ambiguous overload for operator -- cross-compile riscv64-unknown-elf- #1484

ThibFrgsGmz Jun 1, 2022

Replies: 4 comments · 5 replies

ThibFrgsGmz Jun 1, 2022 Author

Joshua-Anderson Jun 1, 2022

Joshua-Anderson Jun 1, 2022

ThibFrgsGmz Jun 2, 2022 Author

ThibFrgsGmz Jun 1, 2022 Author

Joshua-Anderson Jun 1, 2022

ThibFrgsGmz Jun 1, 2022 Author

kevin-f-ortega Jun 1, 2022 Maintainer

ThibFrgsGmz Jun 2, 2022 Author

Ambiguous overload for operator -- cross-compile `riscv64-unknown-elf-` #1484

ThibFrgsGmz
Jun 1, 2022

Replies: 4 comments 5 replies

ThibFrgsGmz
Jun 1, 2022
Author

Joshua-Anderson
Jun 1, 2022

ThibFrgsGmz Jun 2, 2022
Author

ThibFrgsGmz
Jun 1, 2022
Author

ThibFrgsGmz Jun 1, 2022
Author

kevin-f-ortega
Jun 1, 2022
Maintainer

ThibFrgsGmz Jun 2, 2022
Author