Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have auto-generated .py files be created during make #102

Open
lbleier-GSFC opened this issue Jun 4, 2020 · 0 comments
Open

Have auto-generated .py files be created during make #102

lbleier-GSFC opened this issue Jun 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@lbleier-GSFC
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The auto-generated .py files that are created by pyuic5 in order to interface between pyqt5 and the UI are unnecessarily caught in various checks (e.g. lgtm) and git commits. As these are auto-generated, checking them is unnecessary and adds extra complexity to our CM process

Describe the solution you'd like
Keep the .ui files only and use pyuic5 to regenerate the equivalent .py files during the cFS build process.

Additional context
Some end users may not want to use this app, so forcing them to install pyqt5 and related tools is not ideal. Therefore, this should only be done if pyuic5 is actually installed on a user's system and skipped otherwise, with the understanding that the app will be unusable unless built properly.

Requester Info
Leor Bleier, NASA GSFC\Code 582

@lbleier-GSFC lbleier-GSFC self-assigned this Jun 4, 2020
@skliper skliper added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants