Remove remaining stray references to old event types

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
While updating event type constants in nasa/cFE#2221 it was noticed that a few stray uses of the old types (CFE_EVS_ERROR, CFE_EVS_INFORMATION etc.) were still present in LC's commented-out tests.

Expected behavior
Update to new event type constants or remove these commented-out tests.

Code snips

LC/unit-test/lc_app_tests.c

Line 470 in 358fc48

(Ut_CFE_EVS_EventSent(LC_SUB_HK_REQ_ERR_EID, CFE_EVS_ERROR, "Error Subscribing to HK Request, MID=0x18A5,

LC/unit-test/lc_app_tests.c

Line 283 in 358fc48

/* UtAssert_True (Ut_CFE_EVS_EventSent(LC_INIT_INF_EID, CFE_EVS_INFORMATION, Message), Message); */

Reporter Info
Avi Weiss @thnkslprpt