Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion block does nothing #5

Open
Gargo opened this issue Apr 6, 2023 · 0 comments
Open

completion block does nothing #5

Gargo opened this issue Apr 6, 2023 · 0 comments

Comments

@Gargo
Copy link

Gargo commented Apr 6, 2023

completion is not called here:

func close(completion: (() -> Void)? = nil) {
        sheetHeight = sheet.frame.height
        closeSheet(animated: true) { _ in
            self.dismiss(animated: true)
        }
    }

what about to rewrite it so:

var completion: (() -> Void)? = nil
func close() {
        sheetHeight = sheet.frame.height
        closeSheet(animated: true) { _ in
            self.dismiss(animated: true, completion: self.completion)
        }
    }
...//add completion param to all `dissmiss` calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant