Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfce support #60

Open
ghost opened this issue Aug 12, 2016 · 11 comments
Open

Xfce support #60

ghost opened this issue Aug 12, 2016 · 11 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 12, 2016

I'm on xfce 4:12, but I think it also concerns other d.e. . The panel has the same style of gtk theme, which is cute but a bit monotonous. I thought that you could adopt a different style for the panels, maybe a dark color, to make it a little differently.
screenshot_2016-08-12_12-09-08
screenshot_2016-08-12_12-08-39

@nana-4
Copy link
Owner

nana-4 commented Aug 19, 2016

Flat-Plat is currently not supported Xfce, but I will support it if I have time.

@bodqhrohro
Copy link

After moving Xfce4-panel to GTK+3 (currently have 4.12.1 on Debian Testing) there appeared a static top padding in the datetime applet. This padding does not depend on font size and does not reproduce with other themes.
2016-11-20-142427_1366x768_scrot

@nana-4
Copy link
Owner

nana-4 commented Dec 1, 2018

I added initial implementation for Xfce theming (GTK3), although it's not yet perfect. (Supporting for GTK2 version is also not yet.)

Tested on Xfce 4.13 (Ubuntu 18.10)

@nana-4
Copy link
Owner

nana-4 commented Dec 1, 2018

TODO:

  • GTK3: FIx #XfceNotifyWindow styling
  • GTK3: FIx #xfwm-tabwin styling
  • Xfwm4: Change frame width to 2px
  • Xfwm4: Change corner radius to 4px
  • GTK2: Support Xfce 4.12 (hopefully)

nana-4 added a commit that referenced this issue Dec 1, 2018
Since xfwm4 doesn't support antialiasing, 4px roundness will be pretty ugly.
@ghost
Copy link

ghost commented Feb 8, 2019

Hello @nana-4

For xfce4-panel (v4.12 GTK2) on standard Materia, I suggest you to use bits from Materia-dark and set panel background to #383838.

Here's what it looks like (I'm using dark variant + #383838 panel bg), don't care about the green colors I customized theme to fit the distro:
capture
edit: didn't see it before uploading, white bottom border is from my VM window, so don't worry about it.

Currently, standard variant panel (with panel bg using theme defaults) is like this:
capture1
BTW, light variant is the same except that dark grey parts are black.

Keep up the good work, Xfce full support would be great. Of course GTK3 will probably come this year, but a lot of distros will be on <4.14 for quite a long time (Ubuntu LTS, Debian, other slow point releases...).

EDIT2: I see that Materia doesn't have a dedicated panel.rc file (which is used by Xfce and iirc MATE).
EDIT3: I tried to make a dedicated panel.rc but menu and some tray icons still have a dark background, with other themes having a good Xfce support, it doesn't happen, I think there's something conflicting in gtkrc or other rc files.

@nana-4
Copy link
Owner

nana-4 commented Feb 11, 2019

Hi @DarthWound, thanks for your suggestion.

I agree that Materia should support v4.12 as well. But Materia uses #212121 instead of #383838 for panels by default. So I'd choose that color unless there is any special reason :)

@ghost
Copy link

ghost commented Feb 11, 2019

Thanks, didn't see the "panel" line in colors.scss :)

EDIT:

Well, with the right color (#212121), my panel.rc (based on zukitwo) is ok (for standard and dark, I didn't tweak light gtkrc yet). It's basic, but should do the job for now.

  • add in gtkrc:
# Panel
gtk-color-scheme = "panel_bg_color:#212121\panel_fg_color:#F2F2F2"

and

include "panel.rc"
  • panel.rc available here (exp in 1 month).

  • Screenshot (again, don't mind the green colors):
    capture d ecran_2019-02-11_11-28-45

@charbelnicolas
Copy link

The materia theme looks beautiful on XFCE, but I was just wondering if it is possible to add a margin to some of the panel buttons so it doesn't look too crowded? or add some padding to the parent panel? Is it possible to modify this?

Screenshot_2019-09-06_22-07-20

Please see the attached image so you can understand what I mean.

Thanks in advance...

@charbelnicolas
Copy link

padding

If would be nice to know if there is a way to make all the buttons behave in the same way as it is with the lightdm gtk greeter settings.

nana-4 added a commit that referenced this issue Sep 12, 2019
Many traditional apps/dialogs are designed bearing in mind that
themes have -GtkDialog-action-area-border.

Noticed by @charbelnicolas in #60 (comment).
@nana-4
Copy link
Owner

nana-4 commented Sep 12, 2019

@charbelnicolas Thanks for your suggestion! They looked too crowded indeed, so I've added some margins to the daialog buttons :)

@charbelnicolas
Copy link

Thanks, that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants