Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does ncdns use "go install"? #2

Open
JeremyRand opened this issue Mar 21, 2019 · 2 comments
Open

Why does ncdns use "go install"? #2

JeremyRand opened this issue Mar 21, 2019 · 2 comments

Comments

@JeremyRand
Copy link
Member

The ncdns project uses go install in its build script, whereas everything in upstream tor-browser-build is using go build. Is there a reason for this? If so, it should probably be documented.
@JeremyRand
Copy link
Member Author

Possibly relevant: http://ea5faa5po25cf7fb.onion/projects/tor/ticket/30334

@JeremyRand
Copy link
Member Author

go install makes cross-compiling more annoying, because linux_amd64 binaries get saved in $GOPATH/bin while all other targets' binaries get saved in places such as $GOPATH/bin/linux_386. (All non-linux_amd64 targets are broken in ncdns-repro right now because of this.)

@JeremyRand JeremyRand mentioned this issue Apr 30, 2019
Merged
JeremyRand added a commit that referenced this issue Jun 8, 2019
@JeremyRand
Merge #21: ncdns: Fix linux/386 builds
62a1a80 
c964910 ncdns: Fix linux/386 builds (JeremyRand)

Pull request description:

  Refs #2 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand