Custom Styles

[gili-labs]

I am unit testing a custom control that separates the concerns of appearance and behavior using styles. I'm looking at the code in ViewInspector that supports styles, such as ButtonStyle, with the goal of trying to determine a way to support custom styles. Does anyone have any ideas?

[gili-labs]

What is the difference between ViewType.ParentView and ViewType.ClassifiedView?

On the surface, they appear nearly equal in all regards, except ViewType.ParentView cannot conform to MultipleViewContent. However, I'm left wondering why?

Is there some subtle reasoning I'm missing.

[gili-labs]

I was playing with the notion of adding the following extension to InspectableView:

@available(iOS 13.0, macOS 10.15, tvOS 13.0, *)
public extension InspectableView {
    func inspectContent() throws -> InspectableView<ViewType.ClassifiedView> {
        return try .init(content, parent: nil, index: nil)
    }
}

This would allow me to do something like this:

extension DefaultResizableFrameHandleStyle {
    func inspect(
        width: Binding<CGFloat?>,
        height: Binding<CGFloat?>,
        isDragging: Bool) throws -> InspectableView<ViewType.ParentView>
    {
        let configuration = ResizableFrameHandleStyleConfiguration(
            width: width,
            height: height,
            isDragging: isDragging)
        let view = try makeBody(configuration: configuration).inspect()
        return try view.inspectContent()
    }
}

This returns an InspectableView with the proper semantics and emulates what you have done already to support SwiftUI styles.

However, I was struggling with the name of the method. I still think this name is alright, but was also toying with the name classify(), which would utterly imply the type of InspectableView returned.

[nalexn]

@gili-labs saw this in your PR, good job! I can see why you needed the classify(), I managed to refactor the original API so this call won't be needed. You can see the current work version in the 0.7.0 branch.

Also, I saw your other comment about some progress with Gestures - nice! I've been doing some work in parallel with you, so please check out the dev branch I mentioned above - there are some major improvements. Also, I noticed swiftlint was missing on my new machine and the code styling went out of control a bit - that's fixed, but I also made it required. Hope that's ok with you

[gili-labs]

@nalexn sorry for the delay in responding. I had four glorious days to work on my stuff, and then yesterday it was back to the grind.

I looked at the refactoring you did. This definitely makes the code more straightforward. I also like the other improvements you did around environment variables.

[nalexn]

Cool! Let me know if I should hold off the release I plan by the end of this week. It has a very important fix for issues around EnvObjects (#62, #87), I finally found a way to inject EnvObjects without appealing to SwiftUI's native mechanism (which requires hosting of views).

[gili-labs]

I still have a lot of testing to do to DragGesture support and I'm probably not going to have time to address it until this weekend. Given the priority on the fixes you've made, I'd go ahead and release as soon as you're ready.