Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the test suite to use nextest and the capture binary from tracy #127

Open
nagisa opened this issue Dec 7, 2024 · 1 comment

Comments

@nagisa
Copy link
Owner

nagisa commented Dec 7, 2024

The current test suite is pretty poor in that it expects the user to bring up a tracy capture session by themselves, and is not really automatic in any way. Furthermore the threaded test runner just fights over the global tracy instance.

Tests cannot really run in parallel or anything like that for those reasons.

A better option would be to:

  • Use cargo-nextest to isolate each test run into a separate process, thus solving "global tracy context" problem;
  • Have each test handle spawning a capture utility from the upstream tracy project, thus recording the traces properly;
  • Implement checks for things we expect to find in the profiles (rather than expecting users to load those profiles into tracy and know what to look for.) Though for the most part our current tests are of "running this sort of valid looking code no longer crashes the process" variety, which don't really require any checks :)
@nagisa
Copy link
Owner Author

nagisa commented Dec 7, 2024

Note that for examples crate it still makes a lot of sense to me to have users to invoke whatever tracy profile ingesters they wish to use with the example (whether it is the GUI interface, or the capture utility.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant