Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table extensions #10

Closed
mrichtsfeld opened this issue Jan 13, 2017 · 8 comments
Closed

Table extensions #10

mrichtsfeld opened this issue Jan 13, 2017 · 8 comments

Comments

@mrichtsfeld
Copy link
Contributor

Hi, first of all, great library.

I'm working a lot with tables and would like to make some extensions there.
First the content alignment is not taken into account for table which means text is always centered.
Second it would be great to pass attributed text to a table which give great flexibility in displaying.

If you don't mind I will implement this and create a PR?

@caloon
Copy link

caloon commented Jan 15, 2017

Another issue I'm having with tables is that there's no carriage return / multi-line support. If the text is too long, it simply gets drawn outside the cell's frame.

@mrichtsfeld
Copy link
Contributor Author

@caloon I also already stumbled over this issue and would need it fixed. I will add it to my changes.

@caloon
Copy link

caloon commented Feb 2, 2017

What is the status on this? Are you still planning to create a PR for tables?

@mrichtsfeld
Copy link
Contributor Author

@caloon yes apart from the multiline support everything is finished so far, I only need to cleanup. I hope I can create a PR next week.

@hemangshah
Copy link

@mrichtsfeld – Have you added the PR? @nRewik – Have you adopted his PR?

@mrichtsfeld
Copy link
Contributor Author

@hemangshah - I did not add it yet. Will do and let you know.

@mrichtsfeld
Copy link
Contributor Author

@hemangshah, @nRewik - I have create a pull request with my changes, please tell me if anything is unclear or needs to be adapted. #14

@nRewik
Copy link
Owner

nRewik commented Sep 24, 2017

Merged with the new release.

@nRewik nRewik closed this as completed Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants