refactor(iroh): move ProtocolHandler impl to iroh-gossip #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2849/docs/iroh/ Last updated: 2024-10-28T14:17:36Z |
matheus23
approved these changes
Oct 28, 2024
Cargo.toml
Outdated
| @@ -51,3 +51,5 @@ iroh-net = { path = "./iroh-net" } | |||
| iroh-metrics = { path = "./iroh-metrics" } | |||
| iroh-test = { path = "./iroh-test" } | |||
| iroh-router = { path = "./iroh-router" } | |||
|
|
|||
| iroh-gossip = { git = "https://github.com/n0-computer/iroh-gossip", branch = "refactor-protocol-impl" } | |||
There was a problem hiding this comment.
We'll wait for iroh-gossip's PR to merge first, then change here, right?
Will we release iroh-gossip to crates.io first and then depend on it from crates.io, or will we keep a git dependency?
There was a problem hiding this comment.
we will keep the git dependency on main until the next release run
|
Ah I see, iroh-gossip is already released. Hum. |
dignifiedquire
force-pushed
the
refactor-move-gossip-protocol
branch
from
809841d
to
2c0b82c
Compare
dignifiedquire
force-pushed
the
refactor-move-gossip-protocol
branch
from
2c0b82c
to
0be007f
Compare
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on n0-computer/iroh-gossip#3