Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md explaining how to run the tests #128

Open
duvet86 opened this issue Mar 21, 2022 · 3 comments
Open

Add CONTRIBUTING.md explaining how to run the tests #128

duvet86 opened this issue Mar 21, 2022 · 3 comments

Comments

@duvet86
Copy link

duvet86 commented Mar 21, 2022

Hello and thanks for the library.

My team and I would like to submit a PR to enable dynamic configuration, similar to what auth0 does with their angular-sdk.

Can you please include a CONTRIBUTING.md explaining how to run the tests. Because apparently the tests fail if I am not replacing the TEST_GTM_ID with a valid key. Is that expected?

Thank you,
Luca

@duvet86
Copy link
Author

duvet86 commented Mar 30, 2022

bump, or we will have to fork it and create a different package.

@mzuccaroli
Copy link
Owner

Sorry for being late , I'm the only mantainer and I'm busy.
While i work on a official CONTRIBUTING.md, I think this is not an expected behavior.

Generally, as you can se, the unit tests are quite small and not updated. I found that the only reliable test are tricky and manual: you need to build the lib, copy the build artifacts in the "node_modules/angular-google-tag-manager/" folder of the demo application and tun it with a real GTM ID.

@duvet86
Copy link
Author

duvet86 commented Mar 30, 2022

Grazie Marco,
sorry for pushing you. I'll submit a PR with the dynamic config very soon.

Thanks for your work,
Luca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants