Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] 432Hz Batch Converter - Option to apply a single overall calculated average pitch to all tracks #39

Open
NintendoManiac64 opened this issue May 17, 2024 · 5 comments

Comments

@NintendoManiac64
Copy link

NintendoManiac64 commented May 17, 2024

There are some situations where you can have either a single song split into multiple files almost like "chapters" (more common in things like visual novels or video games) or you can simply have a single song with two different variations (I recall some very early stereo songs that tend to have mono versions as the more "proper" master simply putt the music on one channel and the vocals on the other).

In such situations, you ideally want the exact same pitch offset applied but, presumably because the pitch analyzer isn't perfect, it can end up with your multiple files ending up with different calculated pitches.

So my idea is an option to calculate the overall average pitch of all the files in the queue, and then apply the same pitch offset to everything. And it should properly account for differences in length too, so if your queue has a 25 second song and a 75 second song, the 75 second song should have 75% of the overall "weight" of the calculated total average pitch (basically what should be the same result if you had added the 75 second song directly after the 25 second song to create a gapless single 100 second song and then ran the pitch analyzer on just the 100 second song by itself)

 
You can simulate and easily test this yourself by simply taking a single song and splitting it into two parts—pretty often you'll find that each part will be calculated as having a different pitch.

@mysteryx93
Copy link
Owner

Could have an option to average per folder.

For a given album, does the pitch vary from one song to the other, or is it generally the exact same pitch throughout the album?

@NintendoManiac64
Copy link
Author

NintendoManiac64 commented May 17, 2024

It's difficult to say because an "album" could be all sorts of things, so honestly I've seen things go either way.

Also it might simply be better to straight-up give more control as to what is used as the basis for pitch calculation; the opening comment was all about calculating an average, but yet another idea is being able to select a specific song and using it as a sort of "ground truth" for pitch calculation that should be applied to everything. This is particularly useful for looping whereby they may just have a short intro that only plays a single time before subsequently playing a main segment that loops over and over (the idea being that you'd want to make the "main" looping portion the "ground truth").

Should I make a separate issue for that second idea, or should I rename this issue to something a bit more generic such as more options for calculating pitch (basing off a single "ground truth" song; applying an average from a folder or the queue)

@mysteryx93
Copy link
Owner

If you want that level of control, you can just set the source pitch manually.

@NintendoManiac64
Copy link
Author

NintendoManiac64 commented May 17, 2024

If you want that level of control, you can just set the source pitch manually.

That's what I do currently, but that requires actually knowing what the calculated source pitch is which only displays with a single decimal place.

The only way to more accurately figure it out is to make sure "skip tempo adjustment" is enabled, then divide the total amount of samples for the resulting waveform by the non-pitch-corrected version and then multiply that factor by 432.

@mysteryx93
Copy link
Owner

That's more like a pitch analyzer module you need.

I'm currently working on launching a new business to sell the highest-vibration jewelry on the planet. If that works well enough, this would free up some of my time to be able to continue working on these apps. And then I could advertise those custom-made rings to app users; as well as some pretty special oil formulas.

@NintendoManiac64 NintendoManiac64 changed the title [Enhancement] 432Hz Batch Converter - Option to apply a single overall calculated average pitch to all tracks [Enhancement] 432Hz Batch Converter - Option to apply a single overall calculated average pitch to all tracks May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants