Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Don't black out summaries for cohesion eds and EIC #43

Open
ylin42 opened this issue Mar 18, 2014 · 4 comments
Open

Don't black out summaries for cohesion eds and EIC #43

ylin42 opened this issue Mar 18, 2014 · 4 comments
Labels

Comments

@ylin42
Copy link
Contributor

ylin42 commented Mar 18, 2014

We're spoiled on everything anyway

@kchen
Copy link
Contributor

kchen commented Mar 18, 2014

I haven't tested this, but I'd be inclined to fix this by reverting 9ad1c72. It seems nice to not special case too many things that are specific to our team, and I think that would also fix this problem (but I haven't checked to make sure). (Plus not special casing not adding people as spoiled means other things like testsolving will correctly not list any puzzles for you to testsolve.)

@ylin42
Copy link
Contributor Author

ylin42 commented Mar 18, 2014

I'm confused - doesn't everyone see the summaries blacked out, regardless of whether they're spoiled?

@kchen
Copy link
Contributor

kchen commented Mar 18, 2014

On the other hand, we could create a spoiledOnEverything privilege, and then have isSpoiled (or whatever the function is called) check both the regular spoiled thing and spoiledOnEverything.

@kchen
Copy link
Contributor

kchen commented Mar 18, 2014

Hmm, I thought there was at least one page that didn't do that, but the few pages I checked do indeed do that for puzzles I'm already spoiled on. Well, I guess one way of fixing this would be to not black out for spoiled puzzles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants