Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

<pre> tag messing up description editing #36

Open
ylin42 opened this issue Mar 12, 2014 · 7 comments
Open

<pre> tag messing up description editing #36

ylin42 opened this issue Mar 12, 2014 · 7 comments
Labels

Comments

@ylin42
Copy link
Contributor

ylin42 commented Mar 12, 2014

[edited by kchen]
<pre> tags in the description aren't processed correctly when a new description is entered. cf http://puzzletron-dev.randomfish.org/puzzle.php?pid=5

(In production, puzzles 74 and possibly also puzzle 1)

@ylin42
Copy link
Contributor Author

ylin42 commented Mar 12, 2014

ah hahaha right, github also allows html tags.

@kchen
Copy link
Contributor

kchen commented Mar 12, 2014

Can you reproduce this in dev and post a link there? (Although I ended up accidentally clicking the puzzletron link instead of the github link, so I guess I'm already marked as spoiled on the puzzle.)

@ylin42
Copy link
Contributor Author

ylin42 commented Mar 12, 2014

@kchen
Copy link
Contributor

kchen commented Mar 12, 2014

Could you clarify what the bug is? When I click the link to show the description, the text within the pre tags appears to be fixed-width, and the change comment also shows fixed width.

@kchen
Copy link
Contributor

kchen commented Mar 12, 2014

Oh wait, it looks like the change comment differs from the actual description.

@ylin42
Copy link
Contributor Author

ylin42 commented Mar 12, 2014

It's not a problem with the fixed width-ness, it's that the entire old description should be collapsed, not just the part until the tag.

Compare to http://puzzletron-dev.randomfish.org/puzzle.php?pid=4 where I changed the description a few times. You don't see any part of the old description at all in the comment thread, unless you click.

@kchen
Copy link
Contributor

kchen commented Mar 17, 2014

#42 notes that the <pre> tag also has double line spacing instead of single.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants