Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see the updates commit status in the pull request #765

Open
NoamGaash opened this issue Nov 27, 2024 · 2 comments
Open

Can't see the updates commit status in the pull request #765

NoamGaash opened this issue Nov 27, 2024 · 2 comments

Comments

@NoamGaash
Copy link

Hi, thank you for maintaining this project!

We're trying to use this action to add a commit status that links to a playwright test reporter we have uploaded -
https://github.com/hasadna/open-bus-map-search/actions/runs/12035311399/job/33554660712?pr=951
but it seems like it doesn't update the pull request on github:
image
image

Are we doing something wrong?

      - name: Set test results
        uses: myrotvorets/set-commit-status-action@master
        if: always() && ${{ env.AWS_KEY_ID }}
        with:
          sha: ${{ github.sha }}
          token: ${{ secrets.GITHUB_TOKEN }}
          description: 'Playwright html report with traces'
          status: ${{needs.test.result}}
          context: 'Test results'
          targetUrl: 'https://s3.amazonaws.com/noam-gaash.co.il/${{ github.run_id }}/open-bus/${{ github.sha }}/test-results/index.html'

Thank you 🙏

@myrotvorets-team
Copy link
Collaborator

It sets the status of the commit, not the pull request.

Screenshot_20241216_042907

@myrotvorets-team
Copy link
Collaborator

If I get what you want, you need to invoke this action twice: set the status to pending first, then run your pipeline, then set the status to the final outcome.

Example: https://github.com/myrotvorets/set-commit-status-action/actions/runs/12344741285/workflow#L46-L59

Screenshot_20241216_043506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants