Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: how are server labels supported? #100

Closed
tgruenert opened this issue Sep 21, 2020 · 9 comments
Closed

Question: how are server labels supported? #100

tgruenert opened this issue Sep 21, 2020 · 9 comments

Comments

@tgruenert
Copy link

Assuming

  1. new servers should be scheduled manually or automatic to manage higher load.
  2. a loadbalancer is used.

If new nodes created, the load balancer need to know them. As fare as i understand, therefore we have labels at hetzner cloud.

But how can i set a label inside kubernetes / rancher node template to give this label to new provisionied machines at startup?

Maybe i don´t see the white elephant? ;-) Thanks!

@tgruenert
Copy link
Author

This may be duplicate to #93
and an idea for workaround is #93 (comment) ith implementation on https://github.com/BlueBambooStudios/hcloud-connect

Have to check this ;-).

@ItsReddi
Copy link

ItsReddi commented Dec 8, 2020

Beside of your usecase it would be nice to be able to label nodes on at hetzner cloud via node templates

@ricktap
Copy link

ricktap commented Dec 29, 2020

I opened an issue on the docker-machine driver itself (JonasProgrammer/docker-machine-driver-hetzner#56 (comment)). Labels are not supported right now, so there is no way for this project to implement it, without the proposed change on the upstream project. We would need exactly the same feature for the same reasons you described above. Feel free to upvote my issue on the machine driver, in case you still need this to be implemented. I would create a PR on the node driver repository, once the upstream implemented the additional option. The change in here would be relatively simple.

@NotANormalNerd
Copy link

@ricktap Is this still on the table? I am currently setting up a new cluster and would love to use the labels set in Kubernetes for the nodes to be set in Hetzner as well.

@NotANormalNerd
Copy link

@mxschmitt Would you mind merging the PRs and publishing a new Version? Or should we fork and move?

@mxschmitt
Copy link
Owner

mxschmitt commented Jan 9, 2021

@NotANormalNerd I will, is tomorrow enough? Then I can also test it on my own and ensure that it works for the other users.

Thanks for your PR! 💯

@NotANormalNerd
Copy link

Tomorrow would be fast as lightning, also it's sunday, so no hurry. Thanks for your work. There is another PR I just opened, but we have to wait for JonasProgrammer there.

@dj9pz
Copy link

dj9pz commented Jul 15, 2021

Any news on support for serverLabels?
The docker machine driver (https://github.com/JonasProgrammer/docker-machine-driver-hetzner) supports them since version 3.2.0 on January 1st (https://github.com/JonasProgrammer/docker-machine-driver-hetzner/releases/tag/3.2.0):

added --hetzner-server-label option: Servers can now be assigned additional metadata during creation, e.g. for use with k8s and load balancers

Thanks!

@mxschmitt
Copy link
Owner

Labels should work since #109. Will close this issue since it seems integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants