Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile to 2.12.0? #68

Open
daviddenton opened this issue Nov 9, 2016 · 9 comments
Open

Cross compile to 2.12.0? #68

daviddenton opened this issue Nov 9, 2016 · 9 comments

Comments

@daviddenton
Copy link

Is there a plan to add support for the new Scala version? I don't mind submitting a PR to get it done (assuming it's not blocked), but would like to know that it would get released.

:)

@brthanmathwoag
Copy link

This would be cool, any plans on that?

@haakonn
Copy link

haakonn commented Feb 15, 2017

I went ahead and sent PR #74 to cross-compile to 2.12. I really need this myself (this dependency is the final one keeping me from upgrading to 2.12), hope we can move forward with this.

@gaydenko
Copy link

gaydenko commented Mar 6, 2017

As a workaround I use this fork for now: https://github.com/daviddenton/handlebars.scala

@agustafson
Copy link

Hi, @haakonn has kindly put in a PR for this. Is there anybody with merge privs that can merge that PR in please?

@mkantor
Copy link

mkantor commented Jan 14, 2019

Any updates on this? I'm blocked by it as well and am going to end up using the fork.

It looks like there are at least two open PRs addressing this (#74 and #79); @mwunsch what would it take to get one of those merged?

@mkantor
Copy link

mkantor commented Jan 14, 2019

Alternatively, if this project is now abandoned/unmaintained and this is not ever going to happen (which I suspect might be the case), could you let us know @mwunsch?

I'd be happy to open a PR to update the README with a note mentioning that and referring people to the fork (if that sounds reasonable).

@daviddenton
Copy link
Author

daviddenton commented Jan 14, 2019

@mkantor if you want to do the PR work of upgrading my fork to support 2.12 then I'll look at releasing it. I'm not sure what it will take in terms of SBT shenanigans though... :)

@mkantor
Copy link

mkantor commented Jan 14, 2019

work of upgrading my fork to support 2.12

@daviddenton Hmm, based on @gaydenko's comment and the artifacts in Maven Central, I thought that your fork was already compatible with 2.12 (but admittedly I haven't tried it yet). What's left to do?

Also let me know if you'd prefer to take this discussion elsewhere; I'm happy to chat via whatever medium is most convenient for you.

@daviddenton
Copy link
Author

@mkantor lol. Looks like you're right! I admit that I totally forgot publishing this for 2.12 (it was a while ago). If anyone else wants to grab the reins of this fork then please speak up, since I'm not currently working on any Scala projects so I probably won't be paying attention when 2.13 comes around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants