Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless -lonig when building using system libraries #94

Open
ancieg opened this issue Sep 13, 2023 · 1 comment
Open

Useless -lonig when building using system libraries #94

ancieg opened this issue Sep 13, 2023 · 1 comment

Comments

@ancieg
Copy link

ancieg commented Sep 13, 2023

Why does you try to link the module with -lonig when JQPY_USE_SYSTEM_LIBS=1?
It's needed only for building libjq itself as I understand.

If I compile the module with link_args_deps = ["-ljq"] in setup.py:111, it even passes all of the tests in tests directory.

@VladislavGlinkin
Copy link

The problem is relevant(
You have to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants