Skip to content

Commit

Permalink
fixed a couple of missed linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
mvisonneau committed Apr 9, 2020
1 parent aee427e commit e9e5a0c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/schemas/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (cfg *Config) ComputeNewVariableExpirations(updatedVariables Variables, exi
}

// Cleanup maps which could turn out to be empty
for k, _ := range variableExpirations {
for k := range variableExpirations {
if len(variableExpirations[k]) == 0 {
delete(variableExpirations, k)
}
Expand Down
4 changes: 2 additions & 2 deletions lib/schemas/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestConfigGetVariableTTL(t *testing.T) {
assert.Equal(t, thirtyMinuteDuration, ttl)

// With an incorrect value in the variable definition
ttl, err = testConfig.GetVariableTTL(&Variable{TTL: pointy.String("foo")})
_, err = testConfig.GetVariableTTL(&Variable{TTL: pointy.String("foo")})
assert.Error(t, err)

// Using the default configuration value
Expand All @@ -71,7 +71,7 @@ func TestConfigGetVariableTTL(t *testing.T) {
},
}

ttl, err = incorrectDefaultConfig.GetVariableTTL(&Variable{})
_, err = incorrectDefaultConfig.GetVariableTTL(&Variable{})
assert.Error(t, err)

// Without any configuration
Expand Down

0 comments on commit e9e5a0c

Please sign in to comment.