Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/shfmt: prefix editorconfig properties #1094

Open
sdavids opened this issue Sep 20, 2024 · 3 comments
Open

cmd/shfmt: prefix editorconfig properties #1094

sdavids opened this issue Sep 20, 2024 · 3 comments

Comments

@sdavids
Copy link
Contributor

sdavids commented Sep 20, 2024

You should prefix the .editorconfig properties defined by shfmt.

Similar to what JetBrains does:

Editorconfig

Generic IntelliJ options that have the ij_ prefix and are applicable to all languages

Otherwise different tools might interpret the same key differently defeating the whole purpose of using .editorconfig in the first place.

@mvdan
Copy link
Owner

mvdan commented Sep 20, 2024

Is this something that editorconfig themselves recommend? I don't oppose the idea, but I'd also prefer to stick to the upstream recommendations.

@sdavids
Copy link
Contributor Author

sdavids commented Sep 20, 2024

editorconfig/editorconfig#516

@mvdan
Copy link
Owner

mvdan commented Sep 20, 2024

OK thanks. I will follow that thread for now.

@mvdan mvdan changed the title Prefix editorconfig properties cmd/shfmt: prefix editorconfig properties Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants