-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Localize #67
Comments
@jermy-c Could you please complete this task in the next week? |
Localization LibraryLingui is the localization library chosen. Pros
<T msg="Click # for more information">
<a href="/about">{$t`here`}</a>
</T>
Cons
IMPORTANT!
|
Interesting choice. Looks very good!
Can you please make a PR with the code changes? Before, please carefully review yourself. Make sure the above criteria are met.
|
Merged
Merged
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Options:
Considerations:
tr('Some English words ending with {ending}', {ending})
, i.e. have the English string hardcoded. This is a) more fail-safe, and b) avoids that we have to invent new string IDs and c) allows to delay the localization during development, not touching multiple files all the time.Tasks:
The text was updated successfully, but these errors were encountered: