From 8b3e067b75eee7756647f22a6f41cc9d1a270e32 Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Fri, 27 Oct 2023 14:13:00 +0200 Subject: [PATCH] lint fixes --- music_assistant/server/controllers/metadata.py | 2 +- music_assistant/server/helpers/database.py | 4 ++-- music_assistant/server/helpers/tags.py | 2 +- music_assistant/server/providers/filesystem_local/base.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/music_assistant/server/controllers/metadata.py b/music_assistant/server/controllers/metadata.py index 338abbff4..33828769a 100755 --- a/music_assistant/server/controllers/metadata.py +++ b/music_assistant/server/controllers/metadata.py @@ -208,7 +208,7 @@ async def get_playlist_metadata(self, playlist: Playlist) -> None: # if playlist has no default image (e.g. a local playlist) if images and (not playlist.image or playlist.image.provider != "url"): if playlist.image and self.mass.storage_path in playlist.image.path: - # re-use previous created path + # reuse previous created path img_path = playlist.image.path else: img_path = os.path.join(self.mass.storage_path, f"{uuid4().hex}.png") diff --git a/music_assistant/server/helpers/database.py b/music_assistant/server/helpers/database.py index f50726751..89e927218 100755 --- a/music_assistant/server/helpers/database.py +++ b/music_assistant/server/helpers/database.py @@ -101,7 +101,7 @@ async def insert( sql_query = f'INSERT OR REPLACE INTO {table}({",".join(keys)})' else: sql_query = f'INSERT INTO {table}({",".join(keys)})' - sql_query += f' VALUES ({",".join((f":{x}" for x in keys))})' + sql_query += f' VALUES ({",".join(f":{x}" for x in keys)})' await self.execute(sql_query, values) await self._db.commit() # return inserted/replaced item @@ -120,7 +120,7 @@ async def update( ) -> Mapping: """Update record.""" keys = tuple(values.keys()) - sql_query = f'UPDATE {table} SET {",".join((f"{x}=:{x}" for x in keys))} WHERE ' + sql_query = f'UPDATE {table} SET {",".join(f"{x}=:{x}" for x in keys)} WHERE ' sql_query += " AND ".join(f"{x} = :{x}" for x in match) await self.execute(sql_query, {**match, **values}) await self._db.commit() diff --git a/music_assistant/server/helpers/tags.py b/music_assistant/server/helpers/tags.py index d309173d6..b6496e35a 100644 --- a/music_assistant/server/helpers/tags.py +++ b/music_assistant/server/helpers/tags.py @@ -20,7 +20,7 @@ # the only multi-item splitter we accept is the semicolon, # which is also the default in Musicbrainz Picard. -# the slash is also a common splitter but causes colissions with +# the slash is also a common splitter but causes collisions with # artists actually containing a slash in the name, such as ACDC TAG_SPLITTER = ";" diff --git a/music_assistant/server/providers/filesystem_local/base.py b/music_assistant/server/providers/filesystem_local/base.py index d8962f745..d7805e744 100644 --- a/music_assistant/server/providers/filesystem_local/base.py +++ b/music_assistant/server/providers/filesystem_local/base.py @@ -703,7 +703,7 @@ async def _parse_track( # track artist(s) for index, track_artist_str in enumerate(tags.artists): - # re-use album artist details if possible + # reuse album artist details if possible if track.album and ( album_artist := next( (x for x in track.album.artists if x.name == track_artist_str), None