Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resume download by not using cache date. #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredericgermain
Copy link

Do not use cache date if trying to resume download: if
the "If-Modified-Since:" HTTP header is present, Apple
servers ignores the Range: HTTP header.

Do not use cache date if trying to resume download: if
the "If-Modified-Since:" HTTP header is present, Apple
servers ignores the Range: HTTP header.
@fredericgermain
Copy link
Author

So actually, my patch fails when the file is complete (needed to download the big dmg file to see that), the server might send a 416 range not satisfiable.

I would just ignore curl error in this case maybe, the script would work. Getting detailed error with the python/curl subprocess is quite cumbersome...

@gregneagle gregneagle closed this Jun 15, 2020
@gregneagle gregneagle reopened this Jun 16, 2020
@gregneagle gregneagle changed the base branch from master to main June 16, 2020 04:01
@craig65535
Copy link
Contributor

I think this is obsoleted by #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants