Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always package whole Cargo project #50

Closed
andreibancioiu opened this issue Jan 2, 2024 · 2 comments
Closed

Always package whole Cargo project #50

andreibancioiu opened this issue Jan 2, 2024 · 2 comments
Assignees
@andreibancioiu
Labels
task

Comments

@andreibancioiu
Copy link
Contributor

andreibancioiu commented Jan 2, 2024 •
edited
Loading

In #44, we allow one to optionally package the whole Cargo project. In the near future, we should forbid the alternative.

Impact: the packaged source code would be larger (with respect to the size of the codebase), but the dependencyDepth hints can be used by downstream applications to filter out some files. E.g. MultiversX Explorer already leverages dependencyDepth to filter files on the Verified Contract / Code tab.
@andreibancioiu andreibancioiu self-assigned this Jan 2, 2024
@andreibancioiu andreibancioiu changed the title v7: Always package whole Cargo project Always package whole Cargo project Jan 3, 2024
@andreibancioiu
Copy link
Contributor Author

Fixed by:

@andreibancioiu andreibancioiu mentioned this issue May 28, 2024
Merged
@andreibancioiu
Copy link
Contributor Author

Fixed by #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreibancioiu andreibancioiu

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreibancioiu