Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change version tag "vX.Y.Z-R" to "X.Y.Z-R". #92

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Change version tag "vX.Y.Z-R" to "X.Y.Z-R". #92

merged 1 commit into from
Sep 2, 2019

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Sep 1, 2019 •
edited
Loading

To align a general container's version tag rule on DockerHub and etc.

This fixes #91 .

After this PR is merged, I will run the pipeline for qemu "3.1.1-2", "4.0.0-4", "4.0.0-5" (again) and the latest version "4.1.0-1".
https://src.fedoraproject.org/rpms/qemu/blob/master/f/qemu.spec

The created images look good.

https://travis-ci.org/multiarch/qemu-user-static/builds/579575711#L1306

$ docker images
REPOSITORY                   TAG                           IMAGE ID            CREATED                  SIZE
multiarch/qemu-user-static   register                      d8cfc7ba0dab        Less than a second ago   1.25MB
multiarch/qemu-user-static   4.0.0-5                       201fb779d319        1 second ago             133MB
multiarch/qemu-user-static   latest                        201fb779d319        1 second ago             133MB
multiarch/qemu-user-static   x86_64-xtensa                 4bda0d5739f9        11 seconds ago           4.65MB
multiarch/qemu-user-static   x86_64-xtensa-4.0.0-5         4bda0d5739f9        11 seconds ago           4.65MB
multiarch/qemu-user-static   xtensa                        4bda0d5739f9        11 seconds ago           4.65MB
multiarch/qemu-user-static   xtensa-4.0.0-5                4bda0d5739f9        11 seconds ago           4.65MB
...

@junaruga
Change version tag "vX.Y.Z-R" to "X.Y.Z-R".
100ea04 
To align a general container's version tag rule on DockerHub and etc.
@junaruga junaruga requested review from lafin and moul September 1, 2019 23:25
moul
moul approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@junaruga junaruga merged commit 17a33d7 into multiarch:master Sep 2, 2019
@junaruga junaruga deleted the feature/version-tag branch September 2, 2019 09:18
@junaruga
Copy link
Member Author

junaruga commented Sep 2, 2019

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@lafin lafin Awaiting requested review from lafin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image version tag to change from "vX.Y.Z-R" to "X.Y.Z-R"
2 participants
@junaruga @moul