Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image version tag to change from "vX.Y.Z-R" to "X.Y.Z-R" #91

Closed
junaruga opened this issue Aug 26, 2019 · 0 comments · Fixed by #92
Closed

Image version tag to change from "vX.Y.Z-R" to "X.Y.Z-R" #91

junaruga opened this issue Aug 26, 2019 · 0 comments · Fixed by #92

Comments

@junaruga
Copy link
Member

Is this a bug report, feature (enhancement) request or question? (leave only one on its own line)

/kind enhancement

Description:

We recently released new feature to add version tag images (#74 (comment)) by the PR #84 .

I added the version tag vX.Y.Z-R with people's agreements.
The philosophy came from fX.Y.Z-R and dX.Y.Z-R of https://github.com/dbhi/qus .
I thought if our version tag meant common version tag, I thought vX.Y.Z-R was good to mean the common version.
But in case of this project, I think X.Y.Z-R is better than vX.Y.Z-R, after rethinking it. Because the version string without v is very common in the container version rule such as https://hub.docker.com/_/alpine .

I admit I made mistake.

So, you like I like to change the image version tag to change from "vX.Y.Z-R" to "X.Y.Z-R".
Then I want to run the pipeline for 3.1.1-2, 4.0.0-4 and 4.0.0-5 again.

How do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant