Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add a new section for Integration #4411

Merged
merged 11 commits into from
Nov 22, 2024
Merged

[docs] Add a new section for Integration #4411

merged 11 commits into from
Nov 22, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 13, 2024 •
edited
Loading

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Nov 13, 2024
@prakhargupta1 prakhargupta1 linked an issue Nov 13, 2024 that may be closed by this pull request
[docs] Change the integration docs to an Integration section #4259
Closed
@prakhargupta1
Copy link
Member Author

@bharatkashyap Not sure why Netlify preview fails. Can you have a look?

@bharatkashyap
Copy link
Member

Instead of a root level section, can we make it a sub-section of the Introduction? I think that makes more sense in the hierarchy of the navigation, what do you think?

apedroferreira
apedroferreira requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Vale changes in my own copy :D

Also why did we remove the numbers from the headings?
In the React Router guide I sometimes mention "step 1" or "step 3" but this way it doesn't make sense anymore, we'd have to change it.

docs/data/toolpad/core/integrations/react-router.md Outdated Show resolved Hide resolved
docs/data/toolpad/core/integrations/react-router.md Outdated Show resolved Hide resolved
@prakhargupta1
Copy link
Member Author

Also why did we remove the numbers from the headings?
In the React Router guide I sometimes mention "step 1" or "step 3" but this way it doesn't make sense anymore, we'd have to change it.

Based on the core docs Integration section, I removed the numbers. There were two mentions of step 1, step 2 which I have now tackled.

apedroferreira
apedroferreira approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Prakhar!

@prakhargupta1 prakhargupta1 merged commit e189558 into mui:master Nov 22, 2024
14 checks passed
@prakhargupta1 prakhargupta1 deleted the integration-docs branch November 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap left review comments

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Change the integration docs to an Integration section
3 participants
@prakhargupta1 @bharatkashyap @apedroferreira