-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password fields should be changed to text fields #8
Comments
I just read the wiki, and realized you're already aware of this issue. Sorry. Why not implement this feature? |
Internet Explorer will not allow changing the $('<input type="password"/>'); My concerns in the past have been regarding keeping the plugin as unintrusive as possible; I'm already uneasy about the fact that it modifies Really, I think a better approach would be to use an overlay which would then work for all kinds of |
Okay. Interesting, I just looked at your branch and "copyCSS" seems like an endless function.. I'm afraid an overlay or replacing the input field would open up too many issues, and be very hard to maintain. In fact, I think modifying the "value" is the least intrusive. That would also be what a developer expects. As you mention, the only problem is the IE security restriction, but it's not present in newer versions of IE, which is also why I have decided to let my old IE users see stars. |
In relation to this issue, a whole new range of issues is popping up when using HTML5 input types. I do a lot of webapps for iPads, and especially with phone numbers it's a big advantage to use an input of type "number", but then the example text won't work. |
doesn't the html5 have a placeholder attribute to do this exact thing? I'm thinking that assigning placeholder to the input fields and checking if the browser is HTML5 compatible via modernizr would help you in your ipad+web development. .... html code .... javascript code |
When using example on a password field, you just get a string of stars, not very usefull.
I've used this rather ugly code to change a password field to a text field, when the example text is shown:
Think something similar should be implemented in core. The reason why I'm replacing the input rather than just changing the type attribute is due to some security rule preventing the transform.
The text was updated successfully, but these errors were encountered: