Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew support #4

Open
prydda opened this issue Feb 26, 2019 · 5 comments
Open

Add brew support #4

prydda opened this issue Feb 26, 2019 · 5 comments

Comments

@prydda
Copy link

prydda commented Feb 26, 2019

Nice keeping this alive! Possible to add homebrew support? :)

@muandrew
Copy link
Owner

If theres 10 votes for this I’ll look into it.

@maksimu
Copy link

maksimu commented May 4, 2020

how about if there are 8 votes?

@muandrew
Copy link
Owner

muandrew commented May 11, 2020

One off but I thought I'd get started instead of procrastinating.

Homebrew/homebrew-cask#82354

my notes

set up environment according to
https://github.com/Homebrew/homebrew-cask/blob/master/CONTRIBUTING.md#getting-set-up-to-contribute

generate sha from instructions under
https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#cask-stanzas

tested the following

brew cask install androidtool
brew cask uninstall androidtool
brew cask audit androidtool --download
# audit for androidtool: passed

cd "$(brew --repository)"/Library/Taps/homebrew/homebrew-cask
brew cask style Casks/androidtool.rb [--fix]
# 1 file inspected, no offenses detected

commit convetion according to
https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#commit-messages

@muandrew muandrew reopened this May 11, 2020
@muandrew
Copy link
Owner

will close when it is merged.

@muandrew
Copy link
Owner

Rejected, need to follow the following
https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#forks-and-apps-with-conflicting-names.

I'll reach out to mortenjust and see if he will endorse this project, then I'll proceed to creating another token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants