Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS GovCloud regions not supported #101

Open
jamessevener opened this issue Oct 3, 2024 · 1 comment · May be fixed by #102
Open

AWS GovCloud regions not supported #101

jamessevener opened this issue Oct 3, 2024 · 1 comment · May be fixed by #102
Labels
bug Something isn't working

Comments

@jamessevener
Copy link

jamessevener commented Oct 3, 2024

Describe the bug
AWS GovCloud regions to not match expected region

To Reproduce
Steps to reproduce the behavior:

  1. Deploy k8s-pvc-tagger to AWS GovCloud hosted k8s cluster

Expected behavior
GovCloud regions are supported, and pods don't crash

Additional context
"level":"debug","msg":"ec2Metadata region","region":"us-gov-west-1"
"level":"fatal","msg":"Given AWS_REGION does not match AWS Region format."

regexpAWSRegion = `^[\w]{2}[-][\w]{4,9}[-][\d]$`

Regex doesn't match for gov regions

@jamessevener jamessevener added the bug Something isn't working label Oct 3, 2024
@headkm
Copy link

headkm commented Oct 8, 2024

A workable regex for this would be something like
^[\w]{2}[-][\w]{4,9}[-][\d]$|^[\w]{2}[-][\w]{3}[-][\w]{4,9}[-][\d]$

@jamessevener jamessevener linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants