Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can dispense in fractions even though dispensing is in units of 1 #6090

Open
roxy-dao opened this issue Jan 16, 2025 · 1 comment · May be fixed by #6104
Open

Can dispense in fractions even though dispensing is in units of 1 #6090

roxy-dao opened this issue Jan 16, 2025 · 1 comment · May be fixed by #6104
Assignees
@CarlosNZ
Labels
bug Something is borken feature: dispensing Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Piwakawaka James, Chris, Carl
Milestone
V2.5.0-RC4

Comments

@roxy-dao
Copy link
Contributor

roxy-dao commented Jan 16, 2025 •
edited
Loading

What went wrong? 😲

I can dispense in fractions even if the tablets are in units of 1.

Expected behaviour 🤔

Shouldn't be able to dispense in fractions if the unit is 1!

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Create a prescription
  2. Add an item
  3. Enter a fractional number
  4. Save

Your environment 🌱

  • Open mSupply Version:
  • Legacy mSupply Central Server Version: v2.5.0-RC3
  • Platform:
  • Database type:
@roxy-dao roxy-dao added bug Something is borken needs triage Team Piwakawaka James, Chris, Carl Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. and removed needs triage labels Jan 16, 2025
@roxy-dao roxy-dao added this to the V2.5.0-RC4 milestone Jan 16, 2025
@roxy-dao
Copy link
Contributor Author

Actually there might be rare use case for dispensing to children 🤔 so maybe we want to keep it as decimals? Not sure @andreievg

@CarlosNZ CarlosNZ self-assigned this Jan 16, 2025
CarlosNZ added a commit that referenced this issue Jan 16, 2025
@CarlosNZ
Don't allow fractional units to be dispensed #6090
d6767fb
@CarlosNZ CarlosNZ linked a pull request Jan 16, 2025 that will close this issue
Open
@CarlosNZ CarlosNZ linked a pull request Jan 16, 2025 that will close this issue
#6083 #6090 #6061 #6059 Prescription hotfixes x4 #6104
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlosNZ CarlosNZ

Labels
bug Something is borken feature: dispensing Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Piwakawaka James, Chris, Carl
Projects
None yet
Milestone
V2.5.0-RC4
Development

Successfully merging a pull request may close this issue.

#6083 #6090 #6061 #6059 Prescription hotfixes x4 msupply-foundation/open-msupply
2 participants
@CarlosNZ @roxy-dao