Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prescriptions: Unit Quantity calculation is wrong if the item's Pack Size is higher than 1 #6059

Open
marthakeezy opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6104
Open

Prescriptions: Unit Quantity calculation is wrong if the item's Pack Size is higher than 1 #6059

marthakeezy opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6104
Assignees
@CarlosNZ
Labels
bug Something is borken feature: dispensing Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Piwakawaka James, Chris, Carl
Milestone
V2.5.0-RC4

Comments

@marthakeezy
Copy link

What went wrong? 😲

The title is just my assumption - I am not actually sure where the calculation is wrong, but I think if the Pack Size is higher than 1, then the unit quantity for the item is wrong

Screenshot 2025-01-15 at 2 13 57 PM

Expected behaviour 🤔

Unit Quantity should be calculated correctly, e.g. 10 for the example above

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Have an item that has Pack Size > 1 (either create a new one or modify an existing one)
  2. Go to Dispensary -> Prescriptions and create a new prescription
  3. Add the item to it
  4. Add a few other batches so you are able to expand the prescription
  5. See for the batch that has a higher Pack Size, the Unit Quantity is off

Your environment 🌱

  • Open mSupply Version: V2.5.0-RC3
  • Legacy mSupply Central Server Version: V7.18.00
  • Platform: Google Chrome (browser for Mac)
  • Database type: PostgreSQL
@marthakeezy marthakeezy added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release feature: dispensing labels Jan 15, 2025
@marthakeezy marthakeezy mentioned this issue Jan 15, 2025
Open
68 tasks
@andreievg andreievg added Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. and removed needs daily triage New bug to be triaged by the release team needs triage Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release labels Jan 16, 2025
@andreievg
Copy link
Collaborator

Putting as hotfix in 2.5, we need to be correct with simple calculations

@andreievg andreievg added this to the v2.5.0 milestone Jan 16, 2025
@CarlosNZ CarlosNZ added the Team Piwakawaka James, Chris, Carl label Jan 16, 2025
@CarlosNZ CarlosNZ self-assigned this Jan 16, 2025
CarlosNZ added a commit that referenced this issue Jan 16, 2025
@CarlosNZ
Hotfix for unit quantity column in Expando rows #6059
3953898
@CarlosNZ CarlosNZ linked a pull request Jan 16, 2025 that will close this issue
Open
@CarlosNZ CarlosNZ linked a pull request Jan 16, 2025 that will close this issue
#6083 #6090 #6061 #6059 Prescription hotfixes x4 #6104
Open
@roxy-dao roxy-dao modified the milestones: v2.5.0, V2.5.0-RC4 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlosNZ CarlosNZ

Labels
bug Something is borken feature: dispensing Severity: Hotfix Extreme user impact. Can't finalise invoices. Needs patch release and installation immediately. Team Piwakawaka James, Chris, Carl
Projects
None yet
Milestone
V2.5.0-RC4
Development

Successfully merging a pull request may close this issue.

#6083 #6090 #6061 #6059 Prescription hotfixes x4 msupply-foundation/open-msupply
4 participants
@CarlosNZ @andreievg @roxy-dao @marthakeezy