What went wrong? 😲

Month length is 30 rather than 365/12

https://github.com/msupply-foundation/mobile/blob/38602080d644736191062a02c024a1c7e804678c/src/database/utilities/constants.js#L16
In Mobile after much debate the consensus was to use 365/12 religiously.

OG mostly uses 365.25/12. IDK why mobile opted for 365 😆.

We store as average monthly consumption rather than (average )daily consumption

On pull we translate we convert from daily to monthly and ceil() the value. My concern here is that at the translation layer we're applying a different month length constant and rounding saving it to the record - this could break the math of any of the other fields that were calculated based on the daily_consumption and a different length of month right? So possibly subtly breaking past data. This would bleed back to the central server if the records were pushed again.

Why do we take the ceil()? I'm afraid again of how this may force a facet into all calculations that clients may not be expecting (say in future plugin based suggestions).

Why didn't we just use average_daily_consumption? I'm guessing probably because OMS frontend found it was only showing AMC (for now 😉), so thought to just make the schema match?

Expected behaviour 🤔

How to Reproduce 🔨

Steps to reproduce the behaviour:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Your environment 🌱

• Open mSupply Version:
• Legacy mSupply Central Server Version:

• Platform:

• Database type: