Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code inconsistency from the Paper #31

Open
harveyslash opened this issue Dec 19, 2017 · 5 comments
Open

Code inconsistency from the Paper #31

harveyslash opened this issue Dec 19, 2017 · 5 comments

Comments

@harveyslash
Copy link

I was unable to find any code relating to the sigmoid blending.
What are you using instead ?

@harveyslash
Copy link
Author

also,
in the distance calculation in patch_match , there seems to be an element wise multiplication instead of euclidian distance calculation.

@rozentill
Copy link
Member

@harveyslash
Hi, thanks for your interest on our project.

  1. The step function with a threshold 0.05 is the fast approximation to the sigmoid function mentioned in our paper. It is just used for acceleration purpose.

  2. The negative cosine similarity of normalized vectors is equivalent to the euclidean distance.

@harveyslash
Copy link
Author

Thank you for your reply

I am maintaining the Python version of your paper , https://github.com/harveyslash/Deep-Image-Analogy-PyTorch
I even wrote a pycuda implementation of patchmatch for acceleration.
However, the quality is substantially poorer than yours.

@rozentill
Copy link
Member

Thanks for your effort on reproduction to python. I will take a look to see if I can help you.

@harveyslash
Copy link
Author

If you would like, i can set up my server for you so that you can run everything in jupyter without having to set up anything. Let me know if thats suitable for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants