Suggestions for Redwood support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the import statement for xblock-utils The `xblock-utils` library has been deprecated as a separate package; the `utils` library has been moved into the `XBlock` and should now be imported from `xblock.utils` instead. (openedx/XBlock#675) * Upgrade to XBlock 2 Remove the use of deprecated `xblock.fragment` and direct id_generator parameters. 9openedx/XBlock#680) * Add Python 3.11 to test matrix; Drop Python 3.8 from test matrix * Add a version compatibility matrix to the README Fixes: citynetwork#38
Support versions before and after 2 of the XBlock API. Distinguish using the following logic: * When using a Python version prior to 3.9, assume we need the pre-2 API. * For later Python versions, assume the latest API. This way, we get the correct dependencies installed for Redwood (which uses Python 3.11) and earlier releases (which use 3.8).
Having pipdeptree in the test environment is very helpful in determining what versions of dependencies actually get installed, particularly in a CI pipeline. Add the pipdeptree and pipdeptree-requirements testenvs, and invoke them from the GitHub Actions workflow.
We need to test this XBlock on Python 3.8 (for Open edX releases prior to Redwood), 3.11 (for Redwood), and 3.12 (which is the current latest Python release). There is no real good reason to test on 3.10, so we might as well drop it.
|
Looks good to me! :) |
OK, in that case please feel free to pull this into your topic branch, and squash the fixup commit. :) |
mrtmm
force-pushed
the
redwood
branch
2 times, most recently
from
260f17d to
b79e6d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small modification to citynetwork#44 that attempts to preserve compatibility with pre-Redwood Open edX releases.
In addition, it adds version dependency checking via
pipdeptree, and slightly simplifies the test matrix by removing Python 3.10.