Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falsa broken on python 3.9 #22

Open
samster25 opened this issue Dec 11, 2024 · 0 comments
Open

Falsa broken on python 3.9 #22

samster25 opened this issue Dec 11, 2024 · 0 comments

Comments

@samster25
Copy link

Installed the latest main of falsa with python3.9 and get the following error. I believe this can be fixed with
from __future__ import annotations to backport support of the annotations.

I also believe ruff already has a lint rule for this!

(.venv) ➜  Daft git:(main) falsa --help     

Traceback (most recent call last):
  File "/Users/sammy/code/Daft/.venv/bin/falsa", line 5, in <module>
    from falsa.app import entry_point
  File "/Users/sammy/code/Daft/.venv/lib/python3.9/site-packages/falsa/app.py", line 14, in <module>
    from falsa.local_fs import (
  File "/Users/sammy/code/Daft/.venv/lib/python3.9/site-packages/falsa/local_fs.py", line 27, in <module>
    class GroupByGenerator:
  File "/Users/sammy/code/Daft/.venv/lib/python3.9/site-packages/falsa/local_fs.py", line 35, in GroupByGenerator
    self, size: H2ODatasetSizes | int, k: int, nas: int = 0, seed: int = 42, batch_size: int = 5_000_000
TypeError: unsupported operand type(s) for |: 'EnumMeta' and 'type'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant