Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Shiki and Remark #69

Merged
merged 7 commits into from
Jun 8, 2024
Merged

Expose Shiki and Remark #69

merged 7 commits into from
Jun 8, 2024

Conversation

mrjvs
Copy link
Owner

@mrjvs mrjvs commented Jun 8, 2024

changes:

  • Fix mistakes and clarify some stuff in config documentation
  • Add Shiki and Remark options to guider() entrypoint.
  • Update Guider documentation to reflect the new changes
  • Remove dead projects from showcases
  • Bump versions, so it can immediately be released

@@ -15,20 +13,6 @@ const showcases: ShowcaseType[] = [
imageUrl: pretendoImg.src,
tags: ['guider'],
},
{
title: 'movie-web backend',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rip

@@ -6,7 +6,8 @@
"eslintConfig": {
"extends": [
"@repo/eslint-config"
]
],
"ignorePatterns": ["out/**/*", ".next/**/*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node modules maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although why ignore these if you've changed the linting to run on the src folder?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Src folder was only for create-guider project

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also node_modules are ignore by default by eslint

Copy link
Contributor

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your linting smh

@mrjvs mrjvs merged commit bd62db3 into dev Jun 8, 2024
8 of 10 checks passed
@mrjvs mrjvs deleted the feat-expose-shiki branch June 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants