Crash on Sway master and hardware acceleration

[stacyharper]

Important Information

• mpv version

mpv 0.37.0-818ce7c51a6b9179307950e919983e0909942098 Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
libplacebo version: v6.338.1
FFmpeg version: 6.1
FFmpeg library versions:
   libavutil       58.29.100
   libavcodec      60.31.102
   libavformat     60.16.100
   libswscale      7.5.100
   libavfilter     9.12.100
   libswresample   4.12.100

-- sway version

sway version 1.9-dev-c5fd8c05 (Jan  9 2024, branch 'master')

Reproduction steps

Build and install Sway master, play a video with hardware acceleration.

Probably related to swaywm/sway#7897, and the drop of wl_drm?

Here my full command is mpv -v --no-config --hwdec=auto-safe seedbox/animes/One\ Piece\ KAI\ Saga\ 02\ Baroque\ Works\ VOSTFR\ DVDrip\ FanKai-Knuckalex/One\ Piece\ Kai\ 10\ -\ Arc\ Royaume\ de\ Drum\ -\ part\ 2.mp4 > out.log 2>&1

Expected behavior

It works

Actual behavior

Segmentation fault

Log file

out.log

[llyyr]

Not our bug, as seen from the sway issue. Should be fixed by intel/libva#790

You can also just revert swaywm/sway@7e69a70 temporarily

[sfan5]

It still should not be segfaulting however (unless that's literally libva doing it).
Do you have a backtrace?

[llyyr]

Yes, it is libva doing it intel/libva#788

I guess we can add a check here, but shouldn't need to
https://github.com/mpv-player/mpv/blob/master/video/out/hwdec/hwdec_vaapi.c#L52-L57