Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build frees input string memory #2

Open
usamec opened this issue Jan 21, 2015 · 2 comments
Open

Build frees input string memory #2

usamec opened this issue Jan 21, 2015 · 2 comments

Comments

@usamec
Copy link
Contributor

usamec commented Jan 21, 2015

This line should not be here:
https://github.com/mpetri/FM-Index/blob/master/FM.cpp#L127

I believe, that in C++ most people believe in RAII principle and do not expect FM index to free input string memory.

@mpetri
Copy link
Owner

mpetri commented Jan 22, 2015

you are right. I'm not really maintaining this anymore. You should probably use the sdsl-lite library (https://github.com/simongog/sdsl-lite) which contains many more succinct text indexes besides the FM-index and uses proper c++11 coding practices (at least for the most part).

@RagnarGrootKoerkamp
Copy link

@mpetri could you add the fact that sdsl-lite should be used instead to the top of the readme (or even archive the repository)?

As a user there's already too many fm-index implementations to choose from, and without context on the status of the various codebases it's hard to choose. Having one less in the mix helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants