Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker should ignore resolutions in quoted text #3

Open
heycam opened this issue Dec 23, 2020 · 2 comments
Open

tracker should ignore resolutions in quoted text #3

heycam opened this issue Dec 23, 2020 · 2 comments

Comments

@heycam
Copy link
Collaborator

heycam commented Dec 23, 2020

mozilla/wg-decisions#443 is an issue that was automatically filed by @mozilla-apprentice after noticing a "RESOLVED:" within some quoted text. It should probably ignore quoted text (and perhaps any instance of "RESOLVED:" not at the start of a line).

@heycam
Copy link
Collaborator Author

heycam commented Dec 23, 2020

And I guess this is because it's looking at the issue comment as plain text rather than Markdown or HTML, and in plain text the quote marker doesn't get converted into a > or anything.

https://github.com/heycam/wg-tracker/blob/5ddf4f77a276f7cc41a3c4412c8ff56a06db9f59/src/query/issue_comments.graphql#L1-L18

https://github.com/heycam/wg-tracker/blob/5ddf4f77a276f7cc41a3c4412c8ff56a06db9f59/src/github_schema.graphql#L1404-L1407

@heycam
Copy link
Collaborator Author

heycam commented Dec 23, 2020

Parsing Markdown / HTML doesn't sound fun here. Maybe we can remember resolution text that we've already handled on a given issue, and avoid filing a new issue if we've already seen the resolution before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant