Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bunyan #2456

Closed
avi12 opened this issue Jul 12, 2022 · 5 comments · Fixed by #3214
Closed

Remove bunyan #2456

avi12 opened this issue Jul 12, 2022 · 5 comments · Fixed by #3214

Comments

@avi12
Copy link

avi12 commented Jul 12, 2022

Is this a feature request or a bug?

In-between

What is the current behavior?

web-ext depends on

"bunyan": "1.8.15",

which depends on [email protected], that has a security vulnerability that affects my Chrome extensions

What is the expected or desired behavior?

Please switch to a different package other than bunyan, as it seems to no longer be maintained (the last update was 2 years ago)

@willdurand
Copy link
Member

That makes sense. I think we adopted Pino in our other projects. Pino used to be a drop-in replacement for bunyan a long time ago but it has evolved a lot since then. That might still be a straightforward replacement, though.

@fregante
Copy link
Contributor

Are you open to a PR? Dependency-wise the project is huge and quite behind:

I worked on this before and I can do a little more cleaning again:

@willdurand
Copy link
Member

sure thing

@fregante
Copy link
Contributor

fregante commented Jul 15, 2024

Sounds good! I can send a PR after most of the dependabot PRs are merged, there are a lot of low-hanging fruits there that would cause conflict with a Bunyan replacement PR.

update-notifier for example just dropped 21 dependencies

And the PR on this repo is ready and mergeable.

open v10 also shed a lot of weight: https://packagephobia.com/result?p=open

@fregante
Copy link
Contributor

fregante commented Aug 4, 2024

Good to see that those PRs were merged last week! I sent a PR for Pino:

Also there the open PRs failed but for unrelated reasons. It just needs a rebase:

You can see how big v9 was: https://packagephobia.com/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants