Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fission as a "compare by" option #635

Open
cpeterso opened this issue Nov 20, 2019 · 10 comments
Open

Add Fission as a "compare by" option #635

cpeterso opened this issue Nov 20, 2019 · 10 comments

Comments

@cpeterso
Copy link

The Firefox Fission team would like to add a "Fission" option to telemetry.mozilla.org's "compare by" drop-down menu.

With Fission enabled, Firefox will create many more content processes than before, which will likely impact memory usage and performance. I'm working with Data Science to create a real dashboard for Fission release readiness metrics, but Fission engineers would also like to do ad hoc comparisons of Fission vs non-Fission for any telemetry probe.

Users with Fission enabled have the fission.autostart pref set. Is that pref value adequate to partition Fission and non-Fission users on telemetry.mozilla.org?

For now, Fission is only relevant for the Firefox Nightly channel, but it might start riding the trains to Beta in 2020 Q2.

@fbertsch
Copy link
Contributor

Great, that should be all we need, since that value is already sent through telemetry.

@fbertsch
Copy link
Contributor

cc @emtwo for GLAM

@tdsmith
Copy link

tdsmith commented Nov 21, 2019

I left a comment on the bug that added this to the telemetry environment, but heads up that the reported value only reflects whether fission.autostart has a value on the user branch. While fission.autostart is off by default, the reported values will be either true (Fission enabled) or missing (Fission disabled). Someday, when Firefox builds start shipping with fission.autostart set to true on the default branch, the reported values from those builds will be either false (Fission disabled) or missing (Fission enabled).

i.e. understanding whether a client has Fission enabled based on this probe will, in the future, require additional knowledge about the build that's sending telemetry.

@cpeterso
Copy link
Author

cpeterso commented Dec 2, 2019

heads up that the reported value only reflects whether fission.autostart has a value on the user branch. While fission.autostart is off by default, the reported values will be either true (Fission enabled) or missing (Fission disabled). Someday, when Firefox builds start shipping with fission.autostart set to true on the default branch, the reported values from those builds will be either false (Fission disabled) or missing (Fission enabled).

@tdsmith - Should we change how the Fission pref is initialized or recorded to make the pref ping processing easier when comparing Fission vs non-Fission?

https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/toolkit/components/telemetry/app/TelemetryEnvironment.jsm#276

@tdsmith
Copy link

tdsmith commented Dec 2, 2019

If you're ready to start reporting this value in telemetry for all users, you can use RECORD_DEFAULTPREF_VALUE instead of RECORD_PREF_VALUE; https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/toolkit/components/telemetry/app/TelemetryEnvironment.jsm#191-193.

@cpeterso
Copy link
Author

cpeterso commented Dec 2, 2019

Thanks. I'll talk with the Fission engineers. I don't see any harm in reporting this pref value for all users now. The pref is locked so the feature itself can only be activated in the Firefox Nightly channel.

@cpeterso
Copy link
Author

cpeterso commented Dec 2, 2019

I filed Fission bug https://bugzilla.mozilla.org/show_bug.cgi?id=1600818.

@cpeterso
Copy link
Author

I filed Fission bug https://bugzilla.mozilla.org/show_bug.cgi?id=1600818.

This bug has been fixed in Firefox 77 Nightly. The fission.autostart pref value is now being recorded using RECORD_DEFAULTPREF_VALUE, so the pref value will always be reported, even when it is the default value (currently false). This should make writing telemetry queries more future-proof when we eventually flip the pref default to true.

@tdsmith - What are the next steps for requesting that a "Fission vs non-Fission" option be added to TMO's "compare by" menu?

@tdsmith
Copy link

tdsmith commented Apr 14, 2020

AIUI that's on GLAM's roadmap, which is the tool that will replace Measurement Dashboard; @rafrombrc is probably the best contact if you have questions about that.

@cpeterso
Copy link
Author

AIUI that's on GLAM's roadmap, which is the tool that will replace Measurement Dashboard; @rafrombrc is probably the best contact if you have questions about that.

@rafrombrc - Is new telemetry browsing UI development focused on GLAM and not TMO? Do you have a demo or timeline you can share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@tdsmith @cpeterso @fbertsch and others