Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks on Evolution dashboard do not retain selected aggregates for categorical histogram #395

Open
mreid-moz opened this issue Feb 13, 2018 · 6 comments

Comments

@mreid-moz
Copy link
Contributor

STR:

  1. visit this permalink
  2. un-select "eOK" key and instead select "eTooLate"
  3. generate a new permalink
  4. load the new permalink
  5. Observe selected keys (it reverts to "eOK" for me).
@chutten chutten self-assigned this Feb 13, 2018
@chutten chutten changed the title Permalinks on Evolution dashboard do not retain selected keys for keyed histogram Permalinks on Evolution dashboard do not retain selected aggregates for categorical histogram Feb 13, 2018
@chutten
Copy link
Contributor

chutten commented Feb 13, 2018

Probably fallout from #377 where I reworked how we load and change measures in the evo dashboard.

@ab0092
Copy link
Contributor

ab0092 commented Feb 23, 2018

@chutten i have gone through the issue and i think the selected aggregate type is not part of the url which is used to restore state of the page. Is it something you are working on or shall i work on this issue

@o0Ignition0o
Copy link
Collaborator

o0Ignition0o commented Feb 25, 2018

It seems like the aggregates are part of the url, eg : "http://0.0.0.0:8000/new-pipeline/evo.html#!aggregates=0!4" but they don't get parsed the right way.

I also don't get what's going on here, it seems like the aggregates key have nothing to do with the applicable values.

This is pretty weird indeed ! :)

I should probably also file a (maybe) followup bug because it seems like I have to click on the aggregate selector twice before it selects anything O_o

@chutten
Copy link
Contributor

chutten commented Feb 26, 2018

Oh geez, the aggregates are saved to the URL using their index? That's... probably "mostly fine" but certainly isn't parsed that way.

@chutten chutten removed their assignment Feb 26, 2018
@gargshruti30
Copy link
Contributor

@chutten @georgf Can I work on this issue ?

@chutten
Copy link
Contributor

chutten commented Mar 21, 2018

Yes you may. It might prove tricky. You may want to start by looking at #404 and at the code in loadStateFromUrlAndCookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants