Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a Value type for u8 and u128. #189

Open
rnewman opened this issue Jan 7, 2020 · 0 comments
Open

Consider adding a Value type for u8 and u128. #189

rnewman opened this issue Jan 7, 2020 · 0 comments
Labels
omission Half way between a bug and an enhancement

Comments

@rnewman
Copy link
Contributor

rnewman commented Jan 7, 2020

This is a bit of a hole/omission.

I was aiming for simplicity when I defined the set of types, and was also following Mentat's type system, which was definitely aimed at higher-level applications; I64 and U64 were sufficient.

I recently find myself doing a lot of stuffing of bitfields/flags into rkv, and it would be convenient to not have to use a 64-bit integer to do it. I doubt there would be significant space savings, or even efficiency in read/write, but it would express intent and give more flexibility to the underlying storage.

Similarly, one can represent a 128-bit integer as a UUID and store it as a Value::Uuid, but it would be neat to be able to use Rust's own u128 (introduced in 1.26) as a value.

@rnewman rnewman added enhancement New feature or request omission Half way between a bug and an enhancement and removed enhancement New feature or request labels Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
omission Half way between a bug and an enhancement
Projects
None yet
Development

No branches or pull requests

1 participant