[Bug]: Annotations Become Visible After Closing the Annotation Editor

[rajatsingh23]

Attach (recommended) or Link to PDF file

test-1.pdf

Web browser and its version

Firefox 133.0

Operating system and its version

Window 11

PDF.js version

v4.8.69

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

1. Open test-1.pdf in Mozilla Firefox that supports annotations (e.g., a PDF file).
2. Activate the annotation editor by clicking highlight on the toolbar.
3. Click on the "Show All" button
4. Close the annotation editor by clicking on the highlight

What is the expected behavior?

The annotations should remain hidden after closing the editor. But the annotations become visible while the "Show All" button is clicked

What went wrong?

annotation.mp4

Link to a viewer

No response

Additional context

No response

Tasks

Preview Give feedback

No tasks being tracked yet.

[rajatsingh23]

"I am interested in fixing this issue myself and would like guidance if needed."

[calixteman]

"I am interested in fixing this issue myself and would like guidance if needed."

Please try to fix it.
Clicking on show all will lead to execute this function:

pdf.js/src/display/editor/tools.js

Line 1750 in c198e0b

case AnnotationEditorParamsType.HIGHLIGHT_SHOW_ALL:

When some existing highlights are edited we just redraw the page without those annotations and then we create some new Highlight objects thanks:

pdf.js/src/display/editor/highlight.js

Line 860 in c198e0b

static async deserialize(data, parent, uiManager) {

When the edit mode is enabled/disabled we call:

pdf.js/src/display/editor/annotation_editor_layer.js

Line 229 in c198e0b

async enable() {

and

pdf.js/src/display/editor/annotation_editor_layer.js

Line 268 in c198e0b

disable() {

[rajatsingh23]

I am new to open source contributions this is my first issue therefore it would be great if you could provide some more instructions to solve this issue.